FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Row Detail should also work with fixed grid height or w/o autoHeight by ghiscoding · Pull Request #473 · ghiscoding/slickgrid-react · GitHub

This repository was archived by the owner on Jun 1, 2025. It is now read-only.
/ slickgrid-react Public archive

fix: Row Detail should also work with fixed grid height or w/o autoHeight - #473

Merged
ghiscoding merged 5 commits into
masterfrom
bugfix/row-detail-auto-height
Mar 19, 2025
ConversationCommits (5)ChecksFiles changed
Merged

fix: Row Detail should also work with fixed grid height or w/o autoHeight#473
ghiscoding merged 5 commits into
masterfrom
bugfix/row-detail-auto-height

Conversation

ghiscoding commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner
  • defining a fixed grid height and/or disabling resizer.autoHeight should expect the Row Detail to still work properly (it wasn't before this PR)
    • the resizer.autoHeight had a side effect of calling row invalidate after the resize and this side effect was in fact hiding the UI problems described above, which meant that in a few occasions, the Row Details weren't invalidated/redrawn properly
  • also rewrite the pre/post templates to use native HTML code instead of HTML string, which is better for perf and also more secure without requiring any sanitization

bolt-new-by-stackblitz Bot commented Mar 11, 2025

Copy link
Copy Markdown

Run & review this pull request in StackBlitz Codeflow.

ghiscoding added the requires Universal change/release code change must first be implement in Slickgrid-Universal label Mar 11, 2025
ghiscoding changed the title fix: Row Detail should also work with fixed grid height or no autoHeight fix: Row Detail should also work with fixed grid height or w/o autoHeight Mar 12, 2025
ghiscoding merged commit c2a3c88 into master Mar 19, 2025
ghiscoding deleted the bugfix/row-detail-auto-height branch March 19, 2025 02:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

requires Universal change/release code change must first be implement in Slickgrid-Universal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL