FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

github: try to make token generation more robust against bad connection by MichaelMure · Pull Request #1045 · git-bug/git-bug · GitHub

github: try to make token generation more robust against bad connection - #1045

Draft
MichaelMure wants to merge 1 commit into
trunkfrom
github-config-resilience
Draft

github: try to make token generation more robust against bad connection#1045
MichaelMure wants to merge 1 commit into
trunkfrom
github-config-resilience

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

akhavr commented Mar 10, 2023

Copy link
Copy Markdown

Sometimes it fails even earlier:

Select option: 1
Github login: akhavr
Error: Get "https://api.github.com/users/akhavr": read tcp 192.168.1.193:52634->140.82.121.6:443: read: connection reset by peer

Will play more with the bridge creation trying to catch most failure modes.

smoyer64 previously approved these changes Apr 7, 2023

smoyer64 left a comment
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should we adopt something like backoff? (https://pkg.go.dev/github.com/cenkalti/backoff/v4). This is probably not the only place that would benefit from retries. We should also output a warning if the users GITHUB_TOKEN isn't valid (has expired, etc) since you technically have a token but you're still rate-limited like an unauthorized user.

Copy link
Copy Markdown

This bot triages pull requests in order to help the maintainers
identify what needs attention, according to the following lifecycle
rules:

  • After 90 days of inactivity, lifecycle/stale is applied
  • After 90 days of inactivity since lifecycle/stale was applied,
    lifecycle/rotten is applied

This bot will not automatically close stale pull requests.

To remove the stale status, you can:

  • Remove the stale label from this pull request
  • Comment on this issue
  • Close this issue
  • Offer to help out with triage and code review

To avoid automatic lifecycle management of this pull request, add
lifecycle/frozen.

Copy link
Copy Markdown
Contributor

Should we adopt something like backoff? (https://pkg.go.dev/github.com/cenkalti/backoff/v4)

yes :)

sudoforge marked this pull request as draft April 7, 2025 04:31
sudoforge changed the base branch from master to trunk June 7, 2025 17:23
sudoforge dismissed smoyer64’s stale review June 7, 2025 17:23

The base branch was changed.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL