FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

WIP: Gitea/Forgejo bridge by mattcen · Pull Request #1077 · git-bug/git-bug · GitHub

WIP: Gitea/Forgejo bridge - #1077

Closed
mattcen wants to merge 9 commits into
git-bug:masterfrom
mattcen:gitea-bridge
Closed

WIP: Gitea/Forgejo bridge#1077
mattcen wants to merge 9 commits into
git-bug:masterfrom
mattcen:gitea-bridge

Conversation

mattcen commented Jul 29, 2023
edited
Loading

Copy link
Copy Markdown

This PR deprecates #1017 (and #890 and #645 before it). I've rebased off current master, updated the feature matrix to the best of my ability, and built the code to confirm I can pull bugs from a Gitea repo.

I've not done anything else so far. I'm very new to Go, so am starting small, but wanted to at least give this a shot because having a Gitea bridge would be valuable to me.

MichaelMure left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Well, as a maintainer, I see the value of having such a bridge, but it's also a bit scary to merge (and have to maintain) a bridge with zero tests, and incomplete like this.

There is a few tiny fixes to do, but the biggest issue is not having the capability to import comments. It seems like it greatly reduce the usefulness of such importer.

Do you think you could implement that part? It seems like there is already the corresponding iterator, it should be "just" a matter of replicating that data into git-bug.

Comment thread bridge/gitea/import.go
return
}

// Loop over all comments

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks like this is a quite important missing feature, no?

Comment thread bridge/gitea/config.go Outdated
Comment thread bridge/gitea/export.go
)

// giteaExporter implement the Exporter interface
type giteaExporter struct {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this whole exporter could be removed (as it's not used), instead of returning those weird errors

Comment thread bridge/gitea/gitea.go Outdated
MichaelMure mentioned this pull request Aug 10, 2023

mattcen commented Aug 12, 2023

Copy link
Copy Markdown
Author

Oh for sure; there's significant work to be done before it's remotely merge-able, hence the "WIP" and "Draft" status. I'm not sure when I'll be in a position to do more than I have already, but wanted to at least share the progress of bringing the previous PRs up to a state where they at least compile and run on the current code-base.

Thanks for the direction in your comments, though; that will certainly make it easier to make a start on this. :)

will-ca commented Sep 2, 2023

Copy link
Copy Markdown

Any thoughts on Forgejo vs Gitea? Looks like they should be basically compatible, and have a good amount of momentum behind them.

mattcen commented Sep 2, 2023

Copy link
Copy Markdown
Author

Software-wise they're currently identical since Forgejo is a soft fork.

Amolith commented Sep 3, 2023

Copy link
Copy Markdown

They're very much compatible at the moment; Gitea clients will work perfectly with Forgejo servers.

I do know some of the people behind Forgejo are also some of the people behind ForgeFed and they're putting a lot of effort into implementing it. If I remember correctly, the primary Gitea maintainers were pretty ambivalent to federated forges, so I can definitely see them diverging in that area further down the line.

Copy link
Copy Markdown

To complete the git issue/PR graph: this address issues #349 (bridge), part of #80 (integration). And has related issue on the gitea side at go-gitea/gitea#6519

Tian Yuanhao and others added 6 commits August 31, 2024 11:39

mattcen commented Aug 31, 2024

Copy link
Copy Markdown
Author

I've had a little time this weekend to poke at this, and have started adding some unit tests (based on those for the Github/Gitlab bridges) to make this easier to develop. Given I'm still learning the language, I figure having a test harness is a particularly good way to proceed. Not sure how far I'll get with the time I have, but… small steps!

Copy link
Copy Markdown

This bot triages pull requests in order to help the maintainers
identify what needs attention, according to the following lifecycle
rules:

  • After 90 days of inactivity, lifecycle/stale is applied
  • After 90 days of inactivity since lifecycle/stale was applied,
    lifecycle/rotten is applied

This bot will not automatically close stale pull requests.

To remove the stale status, you can:

  • Remove the stale label from this pull request
  • Comment on this issue
  • Close this issue
  • Offer to help out with triage and code review

To avoid automatic lifecycle management of this pull request, add
lifecycle/frozen.

bqv commented Nov 30, 2024

Copy link
Copy Markdown

̇

Amolith commented Nov 30, 2024
edited
Loading

Copy link
Copy Markdown

Github stale bot considered harmful

(Doesn't apply as long as the bot isn't configured to close everything after it becomes ''''rotten'''')

sudoforge added area/bridge Relates to bridges (generic) kind/feature Relates to a new feature lifecycle/frozen and removed lifecycle/stale labels Apr 7, 2025

sudoforge commented May 13, 2025
edited
Loading

Copy link
Copy Markdown
Contributor

thank you for all of the hard work that's been put into this so far. i'm going to close this for now to help keep the active board clean, but am in no way rejecting the feature suggestion -- this has just been inactive for a long time.

if you wish to address the feedback and submit an update, you can always check out this tree like so:

$ git fetch https://github.com/git-bug/git-bug.git refs/pull/1077/head
$ git checkout FETCH_HEAD

feel free to ping me in a comment here to reopen the PR (to avoid needing to create a new one).

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/bridge Relates to bridges (generic) kind/feature Relates to a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL