ci: fix the propagation of TEST_USER_GITHUB - #1446
Draft
sudoforge wants to merge 1 commit into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
A typo in the reference to the repository-level `TEST_USER_GITHUB` variable was causing export tests under //bridge/github to be skipped. This change resolves this issue. Change-Id: Ia1ad61e54e305bb073efc6853738d3eed81d576c
sudoforge
marked this pull request as draft
May 18, 2025 00:52
Copy link
Copy Markdown
Contributor
Author
|
this effectively "re-enables" the TestGithubPushPull test, which is horrendously flaky (see the CI failures for this tree). i'm setting this as a draft and wont be merging this until i have time to dig into the flaky test and fix it. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A typo in the reference to the repository-level TEST_USER_GITHUB
variable was causing export tests under //bridge/github to be skipped.
This change resolves this issue.
Change-Id: Ia1ad61e54e305bb073efc6853738d3eed81d576c