gitlab: refactor the iterator, fix bug - #363
Merged
MichaelMure merged 2 commits intoApr 4, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Notably, properly reset sub iterators when changing to the next issue
MichaelMure
force-pushed
the
gitlab-iterator
branch
from
74827dc to
f4ca533
Compare
March 28, 2020 20:23
MichaelMure
force-pushed
the
gitlab-iterator
branch
from
581966d to
b61ee4c
Compare
April 4, 2020 10:06
MichaelMure
force-pushed
the
gitlab-iterator
branch
from
b61ee4c to
903549c
Compare
April 4, 2020 10:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notably, properly reset the label sub iterators when changing to the next issue. Also, it make it easier to add pre-fetching in the future as each iterator is properly decoupled.
It would probably make sense to do the same for github.
Fix #360