FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

expose properties for executing this plugin from command line without specify plugin configuration in pom.xml by cloorc · Pull Request #596 · git-commit-id/git-commit-id-maven-plugin · GitHub

/ git-commit-id-maven-plugin Public

expose properties for executing this plugin from command line without specify plugin configuration in pom.xml - #596

Open
cloorc wants to merge 1 commit into
git-commit-id:masterfrom
cloorc:master
ConversationCommits (1)ChecksFiles changed
Open

expose properties for executing this plugin from command line without specify plugin configuration in pom.xml#596
cloorc wants to merge 1 commit into
git-commit-id:masterfrom
cloorc:master

Conversation

cloorc commented Sep 2, 2022

Copy link
Copy Markdown

Context

We need to execute this plugin with goal revision without specify this plugin in an existing maven project. We can do this by specifying parameters from command line. And this commit is going to expose these parameters to command line is enough.

Contributor Checklist

  • 🆗 Added relevant integration or unit tests to verify the changes
  • 🆗 Update the Readme or any other documentation (including relevant Javadoc)
  • 🆗 Ensured that tests pass locally: mvn clean package
  • 🆗 Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

TheSnoozer commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

Hello,
thanks for your contribution!
I remember that we had issues with those properties / settings and maven.
Effectively the command-line didn't overwrite anything that was encoded in the pom.xml.

For further details see #315 (comment)
I'd need to test if this somehow suffers similar problems. I'm honestly a bit sceptical...

cloorc commented Sep 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

Hello, thanks for your contribution! I remember that we had issues with those properties / settings and maven. Effectively the command-line didn't overwrite anything that was encoded in the pom.xml.

For further details see #315 (comment) I'd need to test if this somehow suffers similar problems. I'm honestly a bit sceptical...

Yes, it seems like a but of Apache Maven itself. The hard-coded skip won't be overrided by command line options. But properties will. Such as :

<properties>
  <xxx.skip>false</xxx.skip>
</properties>
......
<skip>${xxx.skip}</skip>

cloorc commented Sep 20, 2022

Copy link
Copy Markdown
Author

Hello,
thanks for your contribution!
I remember that we had issues with those properties / settings and maven.
Effectively the command-line didn't overwrite anything that was encoded in the pom.xml.

For further details see #315 (comment)
I'd need to test if this somehow suffers similar problems. I'm honestly a bit sceptical...

Hi, could we just leave the maven defection to maven itself? And this feature could be useful without predefined configuration anyway!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL