FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added .tgz Unity packages. by MaikelChan · Pull Request #230 · gitattributes/gitattributes · GitHub

Added .tgz Unity packages. - #230

Open
MaikelChan wants to merge 1 commit into
gitattributes:masterfrom
MaikelChan:unity_tgz
Open

Added .tgz Unity packages.#230
MaikelChan wants to merge 1 commit into
gitattributes:masterfrom
MaikelChan:unity_tgz

Conversation

MaikelChan commented Nov 23, 2024
edited
Loading

Copy link
Copy Markdown

Hi!

Some Unity packages, including official ones, are distributed in .tgz format. Added it to gitattributes.

Copy link
Copy Markdown
Member

Common.gitattributes contains very "common" file extensions like tgz:
https://github.com/gitattributes/gitattributes/blob/master/Common.gitattributes

You can use this or this generator to combine different parts you need (e.g. IDE + Unity + Common + other stuff that are relevant to your project).

Does that work for your scenario?

Copy link
Copy Markdown
Author

Is that really the best approach? I thought the idea was to have one gitattributes that should work with most Unity projects. If we need to obtain the .tgz rule from Common.gitattributes, why then have other file formats in Unity.gitattributes like .png or .jpg when they are also available in Common.gitattributes? I could understand it if it was some rare format used in specific projects, but .tgz is how Unity distributes some of its packages.

Copy link
Copy Markdown

Common.gitattributes contains very "common" file extensions like tgz:

This is specifically adding lfs to a file that is also in Common. As of right now, only Unity contains lfs entries.

#23 indicates that there wasn't interest in adding lfs globally, but maybe opinions have changed in the last 6 years.

FurkanKambay commented Jun 14, 2025
edited
Loading

Copy link
Copy Markdown
Contributor

@ZachTylerPruitt

#23 indicates that there wasn't interest in adding lfs globally, but maybe opinions have changed in the last 6 years.

For reference, I converted everything to use lfs in #195 as per #194 (comment). Not sure if anyone has had problems with it but it's possible. Maybe it quietly fails when LFS isn't installed? In that case, we should definitely revert everything to binary.


For this PR, I think it makes sense to include the extension since we already have all those others.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL