Commit 0582368
Stephan Brandauer
Java: Drive-by: fix oversight in #13823
In PR #13823, we had rewritten the endpoints that are being considered for framework mode. We used to use `DataFlow::ParameterNode` as endpoints.
However, `ParameterNode`s do not exist for the implicit `this` parameter; they also do not exist for bodiless interface-methods.
In PR #13823, we forgot to model that `this` only exists for non-static methods and to only consider parameters that we have source code for.1 parent 5ad984f commit 0582368
1 file changed
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -56,7 +56,7 @@ abstract class FrameworkModeEndpoint extends TFrameworkModeEndpoint { | |||
| 56 | 56 | class ExplicitParameterEndpoint extends FrameworkModeEndpoint, TExplicitParameter { | |
| 57 | 57 | Parameter param; | |
| 58 | 58 | ||
| 59 | - ExplicitParameterEndpoint() { this = TExplicitParameter(param) } | ||
| 59 | + ExplicitParameterEndpoint() { this = TExplicitParameter(param) and param.fromSource() } | ||
| 60 | 60 | ||
| 61 | 61 | override int getIndex() { result = param.getPosition() } | |
| 62 | 62 | ||
@@ -70,7 +70,7 @@ class ExplicitParameterEndpoint extends FrameworkModeEndpoint, TExplicitParamete | |||
| 70 | 70 | class QualifierEndpoint extends FrameworkModeEndpoint, TQualifier { | |
| 71 | 71 | Callable callable; | |
| 72 | 72 | ||
| 73 | - QualifierEndpoint() { this = TQualifier(callable) } | ||
| 73 | + QualifierEndpoint() { this = TQualifier(callable) and not callable.isStatic() and callable.fromSource() } | ||
| 74 | 74 | ||
| 75 | 75 | override int getIndex() { result = -1 } | |
| 76 | 76 | ||
0 commit comments