Java: Promote experimental XXE sinks - #12932
Merged
atorralba merged 7 commits intoMay 17, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
QHelp previews: |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
DCA is uneventful. |
Sorry, something went wrong.
egregius313
approved these changes
May 16, 2023
egregius313
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the experimental XXE sinks submitted in #6564. Also refactors the XXE tests to use InlineFlowTest.
@aschackmull: In the first commit, I moved a class ConstantStringExpr that was present in XmlParsers.qll to RangeUtils.qll because I needed to use it in other files. I think it makes sense for it to be there, but please let me know if you disagree or if you foresee any performance issues.