Go: improve path summary by changing post update nodes - #13473
Closed
owen-mc wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
owen-mc
force-pushed
the
go/improve-path-summary-by-changin-post-update-nodes
branch
from
4843d1c to
9ea23c1
Compare
June 15, 2023 16:02
smowton
reviewed
Jun 16, 2023
Comment thread
go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll
Outdated
| MkImplicitVarargsSlice(CallExpr c) { c.hasImplicitVarargs() } or | ||
| MkFlowSummaryNode(FlowSummaryImpl::Private::SummaryNode sn) | ||
| MkFlowSummaryNode(FlowSummaryImpl::Private::SummaryNode sn) or | ||
| MkPostUpdateNode(IR::Instruction insn) { insn = updatedInstruction() } |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
getAnUpdatedInstruction
Sorry, something went wrong.
Comment thread
go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll
Outdated
| result = IR::evalExprInstruction(any(SendStmt s).getChannel()) | ||
| } | ||
|
|
||
| private IR::Instruction getAccessPathPredecessor2(IR::Instruction insn) { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks like getAWrittenNode is now unused, so we could remove that and getAccessPathPredecessor then remove the 2 here
Sorry, something went wrong.
Comment thread
go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll
Outdated
| result = getAWrittenInstruction() | ||
| } | ||
|
|
||
| private Expr updatedExpr() { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
getAn...
Sorry, something went wrong.
owen-mc
force-pushed
the
go/improve-path-summary-by-changin-post-update-nodes
branch
from
9ea23c1 to
9e4f4fa
Compare
June 16, 2023 10:05
Copy link
Copy Markdown
Contributor
Author
|
Not needed now we have proper post-update nodes in #14751. |
Sorry, something went wrong.
owen-mc
deleted the
go/improve-path-summary-by-changin-post-update-nodes
branch
October 5, 2025 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot will automatically review once the pull request is marked ready for review
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cf. this comment and the surrounding discussion.
This PR adds new data-flow nodes which are used for post-update nodes. This means that the post-update node will now be in the expected place. This should make path summaries easier to understand.