C#: Keep only one framework reference nuget package in standalone - #14707
Merged
tamasvajk merged 2 commits intoNov 8, 2023
Merged
tamasvajk merged 2 commits into
tamasvajk merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
The DCA analysis shows compilation error increases in:
[001] Found .NET Core/Framework DLLs in NuGet packages at /tmp/GitHub/packages/43e4457282c3f9fa/microsoft.netcore.app.ref. Not adding installation directory. [001] Removed reference /tmp/GitHub/packages/43e4457282c3f9fa/microsoft.netframework.referenceassemblies.net471/1.0.3 [001] Removed reference /tmp/GitHub/packages/43e4457282c3f9fa/netstandard.library/2.0.3/lib/netstandard1.0
[001] Found .NET Core/Framework DLLs in NuGet packages at /tmp/GitHub/packages/43e4457282c3f9fa/microsoft.netcore.app.ref. Not adding installation directory. [001] Removed reference /tmp/GitHub/packages/43e4457282c3f9fa/microsoft.netframework.referenceassemblies.net472/1.0.3 [001] Removed reference /tmp/GitHub/packages/43e4457282c3f9fa/netstandard.library/2.0.3/lib/netstandard1.0 |
Sorry, something went wrong.
tamasvajk
marked this pull request as ready for review
November 8, 2023 10:06
michaelnebel
approved these changes
Nov 8, 2023
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Excellent! 👍
Yes, so this happens exactly when different target frameworks are used in different project files (if it was in the same file the assets logic would "catch" this and only use one)?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.