C#: Tracer improvement for dotnet test - #14712
Merged
michaelnebel merged 2 commits intoNov 8, 2023
Merged
michaelnebel merged 2 commits into
michaelnebel merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
michaelnebel
marked this pull request as ready for review
November 7, 2023 15:33
mbg
approved these changes
Nov 7, 2023
mbg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks reasonable!
Sorry, something went wrong.
hvitved
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an absolute path is provided for a .dll or .exe file on an OS where slashes / are used as directory path separators then the tracer fails to identify that dotnet test shouldn't inject the -p:UseSharedCompilation=false (as the call is directly delegated to vstest and doesn't include any compilation).
This is fixed in this PR.