Java: Improve weak crypto query - #17869
Merged
jcogs33 merged 1 commit intoNov 24, 2024
Merged
jcogs33 merged 1 commit into
jcogs33 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jcogs33
force-pushed
the
jcogs33/improve-weak-crypto
branch
from
8fbd6bf to
459d168
Compare
November 3, 2024 23:22
Copy link
Copy Markdown
Contributor
Author
|
DCA alert changes look reasonable. |
Sorry, something went wrong.
jcogs33
marked this pull request as ready for review
November 3, 2024 23:34
egregius313
approved these changes
Nov 21, 2024
egregius313
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
|
Hello, I kindly ask that GitHub:
Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes weak hash algorithms such as MD5 and SHA1 from java/weak-cryptographic-algorithm and adds these cases to java/potentially-weak-cryptographic-algorithm instead.
The removal of weak hash algorithms from java/weak-cryptographic-algorithm aligns with other languages, e.g. #11129.
Consideration
Let me know if there is any concern with changing the behavior of rankedInsecureAlgorithm instead of doing the exclusion for java/weak-cryptographic-algorithm directly in BrokenAlgoLiteral? I chose to do the exclusion in rankedInsecureAlgorithm since doing so automatically adds the weak hash cases to java/potentially-weak-cryptographic-algorithm due to this code.
Note that there were some overlapping results between the two queries for cases where a weak hash algorithm string literal is used as the default value in a getProperty call (e.g. the "MD5" value in this test case). In order to avoid duplicate results for these cases in the java/potentially-weak-cryptographic-algorithm query, I've added an exclusion to InsecureAlgoLiteral.