Add code owners for /shared/ and a catch-all - #20580
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds code ownership for the /shared/ directory by assigning three specific reviewers as code owners. This addresses the current gap where no reviewers are automatically assigned for changes in the /shared/ directory (except for the /shared/quantum/ subfolder).
Key Changes
- Adds code ownership assignment for /shared/ directory to ensure automatic reviewer assignment
Sorry, something went wrong.
|
The code in /shared/quantum/ is/should be owned by my team, @github/ps-codeql. I am the primary maintainer along with @bdrodes. It would be helpful for ongoing development to keep us as the code owner for that subdirectory. (edited for clarity) |
Sorry, something went wrong.
|
@nicolaswill Yes, I have left the line related to that and my understanding is that because it is more specific lower down, it will override the rule I am adding for /shared/. (That's what copilot told me...) |
Sorry, something went wrong.
|
I have created the team github/codeql-shared-libraries-reviewers. |
Sorry, something went wrong.
Currently no one is added as a reviewer, except in the /shared/quantum/ subfolder. I've made a new team github/codeql-shared-libraries-reviewers for this purpose, and added myself and two other volunteers to it.
Also, there is no catch-all. That is, if none of the rules match, then no one will be tagged as a reviewer. I have added the existing team github/codeql-alert-coverage-eng in this role. The catch-all has to be put at the top of the file because the last line which matches a file has precedence.