FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

C#: Report more timing metrics to the console logger. by michaelnebel · Pull Request #20768 · github/codeql · GitHub

/ codeql Public

C#: Report more timing metrics to the console logger. - #20768

Merged
michaelnebel merged 1 commit into
github:mainfrom
michaelnebel:csharp/extractionlogging
Nov 17, 2025
Merged

C#: Report more timing metrics to the console logger.#20768
michaelnebel merged 1 commit into
github:mainfrom
michaelnebel:csharp/extractionlogging

Conversation

michaelnebel commented Nov 6, 2025
edited
Loading

Copy link
Copy Markdown
Contributor

With this change it will be easier to see from the console log

  • How much time we spend in the dependency fetcher (including running source code generators).
  • How much time we spend in compilation + TRAP generation. This is the extraction phase.
  • How much time we spend in total.

With this change it will be easier to inspect the impact of Incremental CodeQL and dependency caching.
Note, that this also changes the meaning of "Extraction completed in..". As this number now only measures, how long the extraction took and not including the dependency fetching.

github-actions Bot added the C# label Nov 6, 2025
michaelnebel added the no-change-note-required This PR does not need a change note label Nov 7, 2025
michaelnebel marked this pull request as ready for review November 7, 2025 08:56
michaelnebel requested a review from a team as a code owner November 7, 2025 08:56
Copilot AI review requested due to automatic review settings November 7, 2025 08:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This PR improves time tracking granularity in the standalone C# extractor by separating extraction time from total execution time in the logging output.

  • Changed the "Extraction completed" log to report analyzerStopwatch.Elapsed instead of overallStopwatch.Elapsed
  • Added a new "Total time" log entry to report the complete execution time including initialization overhead

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

michaelnebel requested a review from hvitved November 14, 2025 08:48
michaelnebel merged commit c0ebc17 into github:main Nov 17, 2025
24 of 25 checks passed
michaelnebel deleted the csharp/extractionlogging branch November 17, 2025 09:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C# no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL