C++: Extract the expanded compiler arguments - #20831
Merged
jketema merged 6 commits intoNov 17, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
cpp/ql/lib/semmle/code/cpp/Compilation.qll
Fixed
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for extracting expanded compiler arguments from response files. When compilers receive arguments like @someFile, they expand the contents of that file. The new compilation_expanded_args table and corresponding QL predicates allow queries to access these expanded arguments.
Key changes:
- Added compilation_expanded_args table to the database schema for storing expanded compilation arguments
- Introduced getAnExpandedArgument() and getExpandedArgument(int i) predicates to the Compilation class
- Provided upgrade/downgrade migration paths for database schema compatibility
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file| File | Description |
|---|---|
| cpp/ql/lib/upgrades/2121ffec11fac265524955fee1775217364d4ca4/upgrade.properties | Defines upgrade metadata for backward compatibility |
| cpp/ql/lib/upgrades/2121ffec11fac265524955fee1775217364d4ca4/semmlecode.cpp.dbscheme | New schema version with compilation_expanded_args table |
| cpp/ql/lib/upgrades/2121ffec11fac265524955fee1775217364d4ca4/old.dbscheme | Previous schema version without expanded args support |
| cpp/ql/lib/semmlecode.cpp.dbscheme | Updated main schema with new compilation_expanded_args table |
| cpp/ql/lib/semmle/code/cpp/Compilation.qll | Added predicates to access expanded arguments |
| cpp/ql/lib/change-notes/2025-11-13-expanded.md | Documents the new feature for release notes |
| cpp/downgrades/1a6854060d5d3ada16c580a29f8c5ce21f3367f8/upgrade.properties | Downgrade configuration to remove expanded args table |
| cpp/downgrades/1a6854060d5d3ada16c580a29f8c5ce21f3367f8/semmlecode.cpp.dbscheme | Schema for downgrade without expanded args |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
cpp/ql/lib/semmle/code/cpp/Compilation.qll
IdrissRio
previously approved these changes
Nov 17, 2025
IdrissRio
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.