Bump clang-format from 17.0.6 to 20.1.8 - #22616
Merged
redsun82 merged 1 commit intoSep 18, 2026
Merged
redsun82 merged 1 commit into
redsun82 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
17.0.6 dropped the spaces around `&&` in C++20 concept conjunctions, emitting `)&&!(`. 20.1.8 formats it correctly, which accounts for the reformat of `swift/extractor/infra/SwiftLocationExtractor.h`. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The version exists and the formatting-only changes preserve semantics.
Review effort: Balanced
Findings: None
Updates the repository’s clang-format pin and applies the resulting formatting changes.
Changes:
- Bumps clang-format from 17.0.6 to 20.1.8.
- Reformats affected C++20 concept conjunctions.
| File | Description |
|---|---|
| .pre-commit-config.yaml | Updates the clang-format revision. |
| swift/extractor/infra/SwiftLocationExtractor.h | Applies clang-format 20.1.8 output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
paldepind
approved these changes
Sep 18, 2026
paldepind
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks great 👍
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the mirrors-clang-format pin in .pre-commit-config.yaml, the only place this repo records the clang-format version.
Only one file formats differently under 20.1.8. 17.0.6 drops the spaces around && in a C++20 concept conjunction, emitting )&&!(; 20.1.8 gets it right:
pre-commit run clang-format --all-files (what swift.yml runs) passes clean.