yeast: Get rid of shorthand form for rules - #22626
Merged
tausbn merged 1 commit intoSep 18, 2026
Merged
tausbn merged 1 commit into
tausbn merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
In practice we were only using this in the tests, since most rules end up doing more complicated things than straight translations anyway.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation, tests, and documentation consistently remove the shorthand form.
Review effort: Balanced
Findings: None
Removes the unused shorthand rule transform syntax from Yeast.
Changes:
- Removes shorthand parsing and related tests.
- Converts remaining tests to explicit templates.
- Updates macro documentation.
| File | Description |
|---|---|
| shared/yeast/tests/test.rs | Removes shorthand tests and uses explicit templates. |
| shared/yeast/doc/yeast.md | Documents only the two supported transform forms. |
| shared/yeast-macros/src/parse.rs | Removes shorthand parsing and code generation. |
| shared/yeast-macros/src/lib.rs | Removes shorthand API documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
tausbn
marked this pull request as ready for review
September 18, 2026 12:03
asgerf
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
shorthand. This would previously expand into
(foo bar: @baz) => (quux baz: {baz})In practice we were only using this in the tests, since most rules end up doing more complicated things than straight translations anyway.