Repository navigation
Unified: captured variables - #22726
Draft
asgerf wants to merge 40 commits into
Draft
asgerf wants to merge 40 commits into
asgerf wants to merge 40 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment on lines
+243
to
+247
| this.isImplicitParameter(callable, pos) and | ||
| result = "[" + pos + " param] " + callable.toString() | ||
| or | ||
| this.isCallableEx(callable) and | ||
| result = "[callable] " + callable.toString() |
These consistency violations originate from the VariableCapture instantation in C#, JS, Python, and Ruby.
The previously-added consistency errors are gone.
Unified also had consistency errors from its LocalSSA instantiation, due to its use of synthetic read nodes to represent post-update positions. Many variables can have a post-update at the same CFG node.
Many tests passed for the wrong reasons, due to the SSA bug. We need more library/operator modelling to actually find these flows.
Switched to TaintTracking and adds some very ad-hoc steps to recover most of the results. Some more tests pass and others fail; these are now consistent with what we actually model.
The C++ instantiation of DataFlowIntegration generated a bad join order
Since the callee itself is now always considered to be an argument, it needs to have a post-update node. This only matters when the callee is a function with captures, but it should be harmless in general.
asgerf
force-pushed
the
unified/captured-variables
branch
from
753f0d4 to
d880379
Compare
October 5, 2026 08:46
Comment thread
shared/ssa/codeql/ssa/Ssa.qll
Comment on lines
+2159
to
+2161
| /** | ||
| * The given `read` reads multiple variables at once. `var` is bound to one of them. | ||
| */ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot will automatically review once the pull request is marked ready for review
At least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.