Repository navigation
Python: Add models for synchronised iterators - #22733
Open
tausbn wants to merge 1 commit into
Open
tausbn wants to merge 1 commit into
tausbn wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
See https://docs.python.org/3.15/library/threading.html#iterator-synchronization We handle these as simple Models-as-Data models.
tausbn
force-pushed
the
tausbn/python315-model-threading-iterators
branch
from
0271a8f to
92a1c91
Compare
October 2, 2026 13:29
tausbn
marked this pull request as ready for review
October 2, 2026 13:39
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The models match the Python 3.15 APIs and are covered across normal data flow, taint flow, aliases, callbacks, and container types.
Review effort: Balanced
Findings: None
Adds Python 3.15 data-flow models for synchronized iterator utilities.
Changes:
- Models element and taint flow through serialize_iterator and concurrent_tee.
- Adds normal-flow and taint-tracking coverage.
- Documents the analysis improvement.
| File | Description |
|---|---|
| python/ql/lib/semmle/python/frameworks/Stdlib.model.yml | Adds threading iterator models. |
| python/ql/lib/change-notes/2026-09-30-python315-threading-iterators.md | Records the new modeling. |
| python/ql/test/library-tests/dataflow/threading-iterators/test.py | Exercises normal data flow. |
| python/ql/test/library-tests/dataflow/threading-iterators/test_taint.py | Exercises taint propagation. |
| python/ql/test/library-tests/dataflow/threading-iterators/options | Configures Python 3 extraction. |
| python/ql/test/library-tests/dataflow/threading-iterators/NormalDataflowTest.ql | Provides the normal-flow test harness. |
| python/ql/test/library-tests/dataflow/threading-iterators/NormalDataflowTest.expected | Contains the generated normal-flow baseline. |
| python/ql/test/library-tests/dataflow/threading-iterators/InlineTaintTest.ql | Provides the taint test harness. |
| python/ql/test/library-tests/dataflow/threading-iterators/InlineTaintTest.expected | Contains the generated taint baseline. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See
https://docs.python.org/3.15/library/threading.html#iterator-synchronization
We handle these as simple Models-as-Data models.