Repository navigation
Python: Model extra_response_headers - #22734
Open
tausbn wants to merge 1 commit into
Open
tausbn wants to merge 1 commit into
tausbn wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This is a field that is (now) available on instances of `SimpleHTTPRequestHandler`, and which is vulnerable to a header injection attack.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
In-place mutations of the header mapping are not modeled, causing missed injection results.
Review effort: Balanced
Findings: 1
Models Python 3.15 SimpleHTTPRequestHandler.extra_response_headers as a response-header sink.
Changes:
- Models constructor and attribute assignments.
- Adds framework and header-injection tests.
- Adds a change note.
| File | Description |
|---|---|
| Stdlib.qll | Adds header-write modeling. |
| test_extra_response_headers.py | Tests framework concepts. |
| extra_response_headers.py | Adds injection scenarios. |
| HeaderInjection.expected | Updates generated expectations. |
| 2026-09-22-python315-http-headers.md | Documents the analysis improvement. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
python/ql/lib/semmle/python/frameworks/Stdlib.qll
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a field that is (now) available on instances of SimpleHTTPRequestHandler, and which is vulnerable to a header injection attack.