Repository navigation
Python: Model new binascii codecs - #22747
Open
tausbn wants to merge 1 commit into
Open
tausbn wants to merge 1 commit into
tausbn wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new models use format identifiers inconsistent with the existing equivalent codec models.
Review effort: Balanced
Findings: 1
Adds Python 3.15 binascii codec models and corresponding tests.
Changes:
- Models Base32, Base85, and Ascii85 encoding/decoding.
- Tests aliases, custom alphabets, and taint propagation.
- Adds a change note.
| File | Description |
|---|---|
| python/ql/lib/semmle/python/frameworks/Stdlib.qll | Adds codec models. |
| python/ql/test/library-tests/frameworks/stdlib/test_binascii.py | Adds model and taint tests. |
| python/ql/lib/change-notes/2026-09-22-python315-binascii.md | Documents the new modeling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
python/ql/lib/semmle/python/frameworks/Stdlib.qll
Outdated
Adds models for various kinds of codecs introduced in Python 3.15. See the change note for more details.
tausbn
force-pushed
the
tausbn/python315-model-new-binascii-codecs
branch
from
644fde3 to
3272fd5
Compare
October 2, 2026 13:54
geoffw0
approved these changes
Oct 7, 2026
geoffw0
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM.
Does Python support models-as-data? I can see these classes fit into the Encoding and Decoding hierarchy, but I was surprised not to see MaD rows.
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds models for various kinds of codecs introduced in Python 3.15. See the change note for more details.