Repository navigation
Docs: update "Customizing library models for <lang>" to cover JSON data extensions - #22753
Draft
nickrolfe wants to merge 9 commits into
Draft
nickrolfe wants to merge 9 commits into
nickrolfe wants to merge 9 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
docs/codeql/codeql-language-guides/customizing-library-models-for-java-and-kotlin.rst
Outdated
Comment thread
docs/codeql/codeql-language-guides/customizing-library-models-for-go.rst
Outdated
Comment thread
docs/codeql/codeql-language-guides/customizing-library-models-for-go.rst
Outdated
nickrolfe
force-pushed
the
nickrolfe/docs-json-data-extensions
branch
from
a50892c to
be95f83
Compare
October 5, 2026 14:11
nickrolfe
force-pushed
the
nickrolfe/docs-json-data-extensions
branch
from
be95f83 to
f41d6b6
Compare
October 5, 2026 14:13
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Two Go examples incorrectly target the nonexistent codeql/go pack instead of codeql/go-all.
Review effort: Balanced
Findings: 1
Updates library-modeling guides to document JSON data extensions while retaining YAML syntax references.
Changes:
- Adds JSON format guidance and converts examples to JSON.
- Updates JSON booleans and comment syntax.
- Updates the GitHub Actions model-pack example to load JSON files.
| File | Description |
|---|---|
| customizing-library-models-for-rust.rst | Adds Rust JSON examples. |
| customizing-library-models-for-ruby.rst | Adds Ruby JSON examples. |
| customizing-library-models-for-python.rst | Adds Python JSON examples. |
| customizing-library-models-for-javascript.rst | Adds JavaScript JSON examples. |
| customizing-library-models-for-java-and-kotlin.rst | Adds Java/Kotlin JSON examples. |
| customizing-library-models-for-go.rst | Adds Go JSON examples. |
| customizing-library-models-for-csharp.rst | Adds C# JSON examples. |
| customizing-library-models-for-cpp.rst | Adds C/C++ JSON examples. |
| customizing-library-models-for-actions.rst | Adds GitHub Actions JSON examples and configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
docs/codeql/codeql-language-guides/customizing-library-models-for-go.rst
Outdated
nickrolfe
force-pushed
the
nickrolfe/docs-json-data-extensions
branch
from
f6d9c1e to
79cefe4
Compare
October 5, 2026 16:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+1 more reviewerAt least 1 approving review is required to merge this pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next CLI release will support JSON data extensions in addition to the existing YAML format. This PR updates the documentation to cover the JSON format and to convert all the example extensions to JSON. (JSON performance noticeably better for packs with lots of extensions).
I'll open separate PRs to convert existing models in this repository once the CLI support is released.