Repository navigation
C#: Data flow for property patterns. - #22757
Draft
michaelnebel wants to merge 4 commits into
Draft
michaelnebel wants to merge 4 commits into
michaelnebel wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
michaelnebel
force-pushed
the
csharp/propertypatternflow
branch
from
74f8c46 to
62a81d4
Compare
October 6, 2026 07:35
michaelnebel
force-pushed
the
csharp/propertypatternflow
branch
2 times, most recently
from
b335b23 to
1638eb2
Compare
October 6, 2026 11:31
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Pattern reads omit fields and can conflate hidden members with identical names.
Review effort: Balanced
Findings: 1
Adds C# data-flow support for values extracted through property patterns.
Changes:
- Adds property-pattern read steps.
- Adds tests for nested, extended, generic, and tuple patterns.
- Adds a change note.
| File | Description |
|---|---|
| Patterns.cs | Adds property-pattern flow cases. |
| PatternFlow.expected | Updates generated test expectations. |
| DataFlowPrivate.qll | Implements pattern-member reads. |
| 2026-10-06-property-pattern-flow.md | Documents the analysis improvement. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll
Outdated
michaelnebel
force-pushed
the
csharp/propertypatternflow
branch
from
1638eb2 to
59612ef
Compare
October 6, 2026 12:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we added data flow support for property patterns. An example of a pattern pattern can be seen in the conditional of the if-statement below.