Java: Promote Cleartext storage of sensitive information using SharedPreferences from experimental - #6468
Merged
atorralba merged 7 commits intoJan 11, 2022
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
java/ql/src/Security/CWE/CWE-312/CleartextStorageSharedPrefs.qhelp
Outdated
This was referenced Aug 17, 2021
Marcono1234
reviewed
Aug 17, 2021
Comment thread
java/ql/src/semmle/code/java/security/CleartextStorageQuery.qll
Outdated
atorralba
force-pushed
the
atorralba/promote-cleartext-sharedprefs
branch
from
68f2fcc to
7cd7ffb
Compare
August 23, 2021 14:55
atorralba
force-pushed
the
atorralba/promote-cleartext-sharedprefs
branch
from
7cd7ffb to
da47abc
Compare
September 3, 2021 11:29
Copy link
Copy Markdown
Contributor
Author
|
Force pushed to rebase #6493. |
Sorry, something went wrong.
ethanpalm
previously approved these changes
Nov 12, 2021
ethanpalm
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
These changes look good from a docs point of view. I just made one small suggestion ⚡
Sorry, something went wrong.
Comment thread
java/ql/src/Security/CWE/CWE-312/CleartextStorageSharedPrefs.qhelp
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Thanks @ethanpalm! Suggestion applied :) |
Sorry, something went wrong.
ethanpalm
previously approved these changes
Nov 12, 2021
aschackmull
reviewed
Jan 5, 2022
Comment thread
java/ql/lib/semmle/code/java/security/CleartextStorageSharedPrefsQuery.qll
Outdated
aschackmull
reviewed
Jan 5, 2022
Comment thread
java/change-notes/2021-08-10-cleartext-storage-sharedprefs-query.md
Outdated
Co-authored-by: Ethan Palm <56270045+ethanpalm@users.noreply.github.com>
- Update CleartextStorage library to latest refactor - Move change note to new location
atorralba
force-pushed
the
atorralba/promote-cleartext-sharedprefs
branch
from
e30ed41 to
e1e5e78
Compare
January 10, 2022 16:11
aschackmull
reviewed
Jan 11, 2022
aschackmull
reviewed
Jan 11, 2022
Comment thread
java/ql/lib/semmle/code/java/security/CleartextStorageSharedPrefsQuery.qll
Outdated
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
aschackmull
reviewed
Jan 11, 2022
Comment thread
java/ql/lib/semmle/code/java/security/CleartextStorageSharedPrefsQuery.qll
Outdated
aschackmull
approved these changes
Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to promote the Cleartext storage of sensitive information using SharedPreferences on Android query created in #4675.
Changes
To Consider
There were three DataFlow::Confiugration working together in this query: SharedPreferencesFlowConfig, EncryptedValueFlowConfig and EncryptedSharedPrefFlowConfig. I removed EncryptedSharedPrefFlowConfig and used DataFlow::localExprFlow instead, to avoid having that many DataFlow::Configuration instances around.