FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

autobuild: add working-directory input by cklin · Pull Request #1024 · github/codeql-action · GitHub

/ codeql-action Public

autobuild: add working-directory input - #1024

Merged
cklin merged 2 commits into
github:mainfrom
cklin:autobuild-working-dir
Apr 8, 2022
ConversationCommits (2)ChecksFiles changed
Merged

autobuild: add working-directory input#1024
cklin merged 2 commits into
github:mainfrom
cklin:autobuild-working-dir

Conversation

cklin commented Apr 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

cklin marked this pull request as ready for review April 7, 2022 17:27
cklin requested a review from a team as a code owner April 7, 2022 17:27

cklin commented Apr 7, 2022

Copy link
Copy Markdown
Contributor Author

@igfoo Do you have any thoughts on how we should test this functionality?

aeisenberg reviewed Apr 7, 2022
View reviewed changes
Comment thread src/autobuild-action.ts Outdated
cklin requested a review from aeisenberg April 7, 2022 22:32

aeisenberg commented Apr 7, 2022

Copy link
Copy Markdown
Contributor

Looks like a spurious failure.

aeisenberg commented Apr 7, 2022

Copy link
Copy Markdown
Contributor

Best way to test this would be to generate a small test project that uses the autobuild action. Create a workflow that runs codeql on that project and make sure to specify a working directory input. Perhaps something similar to the checkout_path tests.

igfoo commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

I've given it a try, and it looks like it works for me; thanks!

cklin closed this Apr 8, 2022
cklin reopened this Apr 8, 2022
aeisenberg approved these changes Apr 8, 2022
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nice

cklin commented Apr 8, 2022

Copy link
Copy Markdown
Contributor Author

Finally got PR Check - Autobuild working directory to work:

cklin merged commit baf90d1 into github:main Apr 8, 2022
cklin deleted the autobuild-working-dir branch April 8, 2022 23:20
This was referenced Apr 27, 2022
Merged
Merged
snyk-bot mentioned this pull request Apr 24, 2023
Open
This was referenced Apr 25, 2023
Open
Open
snyk-bot mentioned this pull request Apr 27, 2023
Open
This was referenced Nov 28, 2023
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL