Support Pipfile without Pipfile.lock - #1026
aeisenberg merged 2 commits into
Conversation
Sorry, something went wrong.
|
Thanks @kojiromike 👍 I rewrote it a bit. I looked at adding a test for this, but the current test setup is a bit too inflexible 😬 (but I did test locally) |
Sorry, something went wrong.
|
Thanks @RasmusWL! Please let me know if there's anything else I can do to help. |
Sorry, something went wrong.
|
@RasmusWL sorry to bug you, but should I continue to keep the branch updated, or just wait for someone from codeql-action-reviewers to get back to this PR? |
Sorry, something went wrong.
cklin
left a comment
There was a problem hiding this comment.
Thank you for the fix!
Sorry, something went wrong.
As previously written, if codeql finds a `Pipfile`, but no `Pipfile.lock`, it will run `pipenv install` with args that require `Pipfile.lock` to exist. Pipfile will fail with this message: ``` Usage: python -m pipenv install [OPTIONS] [PACKAGES]... ERROR:: Pipfile.lock must exist to use --keep-outdated! package installation with pipenv failed, see error above ``` This changeset enables auto_install to work with Pipfile when there is no lock. (Bonus: `--skip-lock` is generally a bit faster.)
Thanks for your work on this, and your continued effort to keep the branch up to date. I would have not have expected you to put in this effort. Once someone from github/codeql-action-reviewers had given the final review, I would have expected them to use the button on this PR page to merge in newest version of default branch (main), and then enable auto-merge. |
Sorry, something went wrong.
As previously written, if codeql finds a Pipfile, but no Pipfile.lock, it will run pipenv install with args that require Pipfile.lock to exist. Pipfile will fail with this message:
This changeset enables auto_install to work with Pipfile when there is no lock. (Bonus: --skip-lock is generally a bit faster.)
Merge / deployment checklist