Fix status reporting error on Windows - #1042
Merged
cklin merged 1 commit intoApr 26, 2022
Merged
cklin merged 1 commit into
cklin merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cklin
marked this pull request as ready for review
April 25, 2022 23:21
edoardopirovano
approved these changes
Apr 26, 2022
aibaars
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1041
Status reporting currently fails on Windows because the CodeQL CLI version number retrieved by the action contains trailing \r\n line ending (so 2.8.5\r\n instead of 2.8.5). Interestingly, the reported CodeQL CLI version similarly contains \n line ending, but that for some reason did not cause server-side validation failure.
This PR fixes the bug by trimming whitespace from codeql version --format=terse output.
Merge / deployment checklist