Don't wait for processing in test mode - #1050
Merged
henrymercer merged 2 commits intoApr 29, 2022
Merged
henrymercer merged 2 commits into
henrymercer merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
In test mode, we don't upload results, so there's no point waiting for processing.
henrymercer
force-pushed
the
henrymercer/dont-wait-for-processing-in-test-mode
branch
from
15f411d to
ea676e3
Compare
April 28, 2022 18:14
aeisenberg
approved these changes
Apr 29, 2022
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice. Good catch.
Sorry, something went wrong.
henrymercer
deleted the
henrymercer/dont-wait-for-processing-in-test-mode
branch
April 29, 2022 09:26
This was referenced May 10, 2022
This was referenced Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In test mode, we don't upload results, so there's no point waiting for processing. Disabling waiting for processing when we're in test mode speeds up most of our PR checks and removes Actions warnings from waiting for processing failing because we didn't upload any SARIF.
Merge / deployment checklist