Run ML-powered queries on Windows with CodeQL CLI 2.9.0+ - #1051
Merged
henrymercer merged 5 commits intoMay 11, 2022
Merged
henrymercer merged 5 commits into
henrymercer merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
henrymercer
force-pushed
the
henrymercer/run-atm-on-windows
branch
from
fdac77d to
ed0abc6
Compare
April 28, 2022 18:22
Copy link
Copy Markdown
Contributor
Author
|
Ready for review, but not ready to be merged yet per the PR description. |
Sorry, something went wrong.
cklin
reviewed
Apr 29, 2022
Comment thread
src/config-utils.test.ts
Outdated
cklin
approved these changes
Apr 29, 2022
Copy link
Copy Markdown
Contributor
Author
|
We're just waiting for ubuntu-18.04 now: https://github.com/actions/virtual-environments/releases/tag/ubuntu18%2F20220503.1 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versions 2.9.0+ of the CodeQL CLI run machine learning models from a temporary directory, which resolves an issue on Windows where TensorFlow models are not correctly loaded due to the absolute path of some of their files being greater than MAX_PATH (260 characters).
We should wait until all virtual environments including CodeQL CLI 2.9.0 have been fully rolled out before merging this PR to avoid alert churn from Code Scanning being run intermittently on the new and old bundles and therefore intermittently running with and without ML-powered queries on Windows.
Merge / deployment checklist