Avoid use of rmdir - #1095
Merged
aeisenberg merged 1 commit intoJun 14, 2022
Merged
Avoid use of rmdir#1095aeisenberg merged 1 commit into
aeisenberg merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This is a deprecated method on node v16.
aeisenberg
force-pushed
the
aeisenberg/use-del
branch
from
c9006c1 to
f7c46e5
Compare
June 13, 2022 22:40
henrymercer
approved these changes
Jun 14, 2022
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
With this change we will no longer retry deleting the directory. However this shouldn't be problematic since the Actions runtime environment isn't affected by the Windows ATP issues, and the runner no longer exists.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yes, it's unclear if we ever actually needed it in the past. |
Sorry, something went wrong.
This was referenced Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a deprecated method on node v16.
Fixes #1091
Merge / deployment checklist