Fix issue with required checks sync script - #1110
Merged
edoardopirovano merged 1 commit intoJun 21, 2022
Merged
edoardopirovano merged 1 commit into
edoardopirovano merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
edoardopirovano
force-pushed
the
edoardo/case-insensitive-update
branch
from
eb6d956 to
5a6f006
Compare
June 21, 2022 12:20
aeisenberg
approved these changes
Jun 21, 2022
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
In the future we should reformat this line to make it easier to read. Maybe just by adding some new lines. Fine the way it is now.
Sorry, something went wrong.
This was referenced Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script didn't quite work on my machine because the update check that we want to filter out was called update and jq was matching in a case-sensitive way so did not filter it out with contains("Update"). Lets add another case to the filter to cover this, to avoid others hitting this issue.
Merge / deployment checklist