FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update required checks: Allow authenticating via the GitHub CLI by henrymercer · Pull Request #1138 · github/codeql-action · GitHub

/ codeql-action Public

Update required checks: Allow authenticating via the GitHub CLI - #1138

Merged
henrymercer merged 5 commits into
mainfrom
henrymercer/drop-token-check
Jul 12, 2022
ConversationCommits (5)ChecksFiles changed
Merged

Update required checks: Allow authenticating via the GitHub CLI#1138
henrymercer merged 5 commits into
mainfrom
henrymercer/drop-token-check

Conversation

henrymercer commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

We no longer run this script within Actions for security reasons, and when running locally we can authenticate with the GitHub CLI instead of a PAT.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

henrymercer requested a review from a team as a code owner July 12, 2022 16:08

adityasharad commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Maybe still keep a log warning, and a comment that this script is meant for interactive use, not as an unattended script. Otherwise in an unattended setting it will hang when it waits for you to authenticate.

Fix shellcheck errors
d61e3fd 
Avoid trying to evaluate `github/codeql-action`.
Allow authenticating via the GitHub CLI
0a5dad3 
We no longer run this script within Actions for security reasons, and
when running locally we can authenticate with the GitHub CLI instead
of a PAT.

henrymercer commented Jul 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I don't really like the idea of logging warnings when everything's fine, particularly when the main use case of this script is running from a dev machine. However I can see the benefit in preventing an unattended script from hanging. I've switched to checking gh auth status at the start of the script instead. This returns a non-zero exit code if the user isn't authed.

henrymercer force-pushed the henrymercer/drop-token-check branch from c225109 to 0a5dad3 Compare July 12, 2022 16:35
Fix extra double quote
fbbd1dc 
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
aeisenberg reviewed Jul 12, 2022
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Forgot to leave this comment earlier.

Comment thread .github/workflows/script/update-required-checks.sh Outdated
Update failure message
816b3e9 
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
henrymercer enabled auto-merge July 12, 2022 16:56
henrymercer merged commit d750c6d into main Jul 12, 2022
henrymercer deleted the henrymercer/drop-token-check branch July 12, 2022 18:57
This was referenced Jul 13, 2022
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL