Use concat instead of push around listFolders - #1139
Merged
aeisenberg merged 2 commits intoJul 13, 2022
Merged
aeisenberg merged 2 commits into
aeisenberg merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
henrymercer
approved these changes
Jul 12, 2022
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good. While we're here, perhaps it's worth auditing the rest of the spread operators in the codebase to make sure these aren't likely to cause a stack overflow.
Sorry, something went wrong.
aeisenberg
force-pushed
the
aeisenberg/concat-not-push
branch
from
e60faa7 to
b7e2196
Compare
July 12, 2022 17:26
This avoids stack overflows when using the spread operator on directories that have many, many children.
aeisenberg
force-pushed
the
aeisenberg/concat-not-push
branch
from
b7e2196 to
7ce9ef9
Compare
July 12, 2022 20:23
Copy link
Copy Markdown
Contributor
Author
|
I did a quick look and did not find any other likely dangerous locations. |
Sorry, something went wrong.
aeisenberg
enabled auto-merge
July 12, 2022 20:24
aeisenberg
disabled auto-merge
July 12, 2022 21:19
aeisenberg
enabled auto-merge
July 12, 2022 21:19
This was referenced Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids stack overflows when using the spread operator on directories that have many, many children.
Merge / deployment checklist