FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Don't crash if we are unable to get a response from the feature-flag endpoint. by criemen · Pull Request #1145 · github/codeql-action · GitHub

Don't crash if we are unable to get a response from the feature-flag endpoint. - #1145

Merged
criemen merged 3 commits into
mainfrom
criemen/fix-ff-crash
Jul 18, 2022
Merged

criemen merged 3 commits into
mainfrom
criemen/fix-ff-crash

Conversation

criemen commented Jul 18, 2022
edited
Loading

Copy link
Copy Markdown
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

criemen requested a review from a team as a code owner July 18, 2022 10:15
criemen enabled auto-merge July 18, 2022 10:20

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A couple of suggestions but otherwise looks good.

Comment thread src/feature-flags.ts
Comment thread src/feature-flags.ts Outdated
criemen disabled auto-merge July 18, 2022 10:37
criemen requested a review from henrymercer July 18, 2022 10:37

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

criemen enabled auto-merge July 18, 2022 10:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL