Round fields in TRAP caching telemetry to integers - #1188
edoardopirovano merged 1 commit into
Conversation
Sorry, something went wrong.
henrymercer
left a comment
There was a problem hiding this comment.
I think keeping them as ints makes sense since it's consistent with the other duration metrics like analyze_builtin_queries_cpp_duration_ms.
Sorry, something went wrong.
| config.trapCaches, | ||
| logger | ||
| trap_cache_upload_duration_ms: Math.round(trapCacheUploadTime || 0), | ||
| trap_cache_upload_size_bytes: Math.round( |
There was a problem hiding this comment.
You could optionally push the rounding in here, if you'll only need the rounded values.
Sorry, something went wrong.
There was a problem hiding this comment.
Hmm, yes, I considered doing that but decided that rounding at the point where we construct the status report was the safest way to make sure we only send an integer to the API. Let's leave it like this for now to unbreak things, and we can always shuffle this around at some other point.
Sorry, something went wrong.
The status reporting API expects these to be integers.
Merge / deployment checklist