TRAP Caching: Unset missing cache rather than setting to undefined - #1207
Merged
edoardopirovano merged 1 commit intoAug 23, 2022
Merged
edoardopirovano merged 1 commit into
edoardopirovano merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
henrymercer
approved these changes
Aug 23, 2022
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM. When we set the property undefined, it still appears in Object.values(...). Deleting it removes it from Object.values(...), so we don't attempt to find its size.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In other parts of the code, we expect the values in the map to not be undefined, so we are getting warnings like https://github.com/github/vscode-codeql/actions/runs/2911692423 if we fail to find a cache in the Actions cache because we are setting a value of undefined here. Let's just remove the language from the map entirely if we don't have a cache for it.
Merge / deployment checklist