Fix Go tracing on Windows, and fix tests - #1209
Merged
henrymercer merged 7 commits intoAug 24, 2022
Merged
henrymercer merged 7 commits into
henrymercer merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
approved these changes
Aug 23, 2022
henrymercer
force-pushed
the
henrymercer/fix-go-tracing-tests
branch
3 times, most recently
from
916e4f2 to
d14f5c9
Compare
August 23, 2022 17:27
These were supplying CODEQL_EXTRACTOR_GO_BUILD_TRACING=true rather than CODEQL_EXTRACTOR_GO_BUILD_TRACING=on, therefore tracing wasn't being tested.
This is currently broken in CLI versions 2.10.3 and earlier.
henrymercer
force-pushed
the
henrymercer/fix-go-tracing-tests
branch
from
bd4e2cc to
569f78c
Compare
August 23, 2022 19:04
Copy link
Copy Markdown
Contributor
Author
|
Rebased on main to address a merge conflict. |
Sorry, something went wrong.
aeisenberg
reviewed
Aug 23, 2022
Comment thread
src/languages.ts
Fixed
It is enough to pass the checks now that we only use the runner for PR checks.
henrymercer
force-pushed
the
henrymercer/fix-go-tracing-tests
branch
from
972fe28 to
182342c
Compare
August 24, 2022 10:50
edoardopirovano
approved these changes
Aug 24, 2022
edoardopirovano
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Seems reasonable. Thanks for the investigation and fix!
Sorry, something went wrong.
6 tasks
4 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Go tracing tests
We're currently supplying CODEQL_EXTRACTOR_GO_BUILD_TRACING=true rather than the expected CODEQL_EXTRACTOR_GO_BUILD_TRACING=on in the PR checks, therefore tracing isn't being tested.
This PR updates the PR checks to the expected CODEQL_EXTRACTOR_GO_BUILD_TRACING=on and also adds an error if it's set to true. Making true a synonym of on is more difficult than it's worth as the Go autobuilder also looks at this environment variable, so whether true is a synonym or not would depend on the version of the CodeQL CLI.
Fix Go tracing on Windows
After fixing the tests, we discovered a bug with Go tracing on Windows with the Lua tracer. We have a fix here: github/codeql#10147. Until this fix is released, we disable Lua tracing on Windows when analyzing Go.
Merge / deployment checklist