Move calls to pack download to the init action - #1218
Merged
aeisenberg merged 3 commits intoAug 30, 2022
Merged
aeisenberg merged 3 commits into
aeisenberg merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
marked this pull request as draft
August 26, 2022 20:48
aeisenberg
force-pushed
the
aeisenberg/move-pack-download-to-init
branch
from
f37d008 to
a666267
Compare
August 26, 2022 21:13
aeisenberg
force-pushed
the
aeisenberg/move-pack-download-to-init
branch
3 times, most recently
from
1e0fc04 to
8948fab
Compare
August 26, 2022 22:35
This ensures all steps to gather queries happens in the init action. This is where checking out queries in other repos happens as well.
aeisenberg
force-pushed
the
aeisenberg/move-pack-download-to-init
branch
from
8948fab to
354bc9f
Compare
August 26, 2022 23:05
aeisenberg
marked this pull request as ready for review
August 29, 2022 15:45
henrymercer
reviewed
Aug 30, 2022
Comment thread
src/config-utils.ts
Outdated
Comment thread
src/config-utils.ts
Outdated
Comment thread
src/config-utils.ts
Outdated
henrymercer
approved these changes
Aug 30, 2022
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
A minor comment about the log messages, otherwise LGTM.
Sorry, something went wrong.
Comment thread
src/config-utils.ts
Outdated
Also, rename variable and change a comment.
aeisenberg
force-pushed
the
aeisenberg/move-pack-download-to-init
branch
from
ad8d70b to
7294b40
Compare
August 30, 2022 16:16
aeisenberg
enabled auto-merge
August 30, 2022 16:16
This was referenced Sep 1, 2022
This was referenced Apr 24, 2023
This was referenced Apr 24, 2023
This was referenced Apr 25, 2023
This was referenced Jun 24, 2023
This was referenced Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures all steps to gather queries happens in the init action. This is where checking out queries in other repos happens as well.
This change is a refactoring that facilitates future changes. In particular, this will help when implementing package download from GHES.
Merge / deployment checklist