Autobuild Go in analyze if not already built - #1219
Merged
henrymercer merged 10 commits intoSep 2, 2022
Merged
henrymercer merged 10 commits into
henrymercer merged 10 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
force-pushed
the
angelapwen/autobuild-in-analyze
branch
from
781cafc to
893add6
Compare
August 26, 2022 22:43
aeisenberg
reviewed
Aug 29, 2022
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Two minor things.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I'll move this PR forward while Angela's on vacation. I'll start by addressing Andrew's review comments and adding a PR check to test the new behavior. |
Sorry, something went wrong.
henrymercer
marked this pull request as draft
August 30, 2022 17:06
henrymercer
force-pushed
the
angelapwen/autobuild-in-analyze
branch
from
3adbc27 to
962795a
Compare
August 31, 2022 11:57
This will enable us to test this behavior in PR checks. Also simplify and add some more detailed documentation.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
`in` checks the indices of an array, not the values.
henrymercer
force-pushed
the
angelapwen/autobuild-in-analyze
branch
from
e86336e to
8e0846c
Compare
August 31, 2022 12:22
henrymercer
marked this pull request as ready for review
August 31, 2022 14:29
aeisenberg
reviewed
Aug 31, 2022
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good. A minor comment.
Sorry, something went wrong.
Comment thread
src/analyze-action.ts
Outdated
3 tasks
aeisenberg
approved these changes
Sep 2, 2022
This was referenced Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will run the autobuilder for Golang in the analyze step if:
This change should be a no-op for now, as if a user has not provided manual build steps for Go, we treat Go as an interpreted language and the autobuilder will run even if users have not included the autobuild action.
With some imminent changes where we will not treat Go as an interpreted language, we introduce this change to maintain backwards compatibility for users who may have removed the autobuild step and who have not provided manual build steps. In this case, we will still autobuild for them at the beginning of the analyze step.
Merge / deployment checklist