Fix running tests on Node 18.8 - #1231
Merged
henrymercer merged 1 commit intoSep 2, 2022
Merged
henrymercer merged 1 commit into
henrymercer merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The [release notes](https://github.com/avajs/ava/releases/tag/v4.3.3) mention compatibility with Node 18.8.
adityasharad
approved these changes
Sep 2, 2022
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Sounds reasonable. I had hoped Dependency Review would show me the other dependencies that were updated in the lockfile as a result, but it's clear what you're primarily changing here.
Sorry, something went wrong.
aeisenberg
approved these changes
Sep 2, 2022
This was referenced Sep 14, 2022
This was referenced Jun 22, 2023
This was referenced Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes errors like this:
when running tests on Node 18.8. The fix is simple: update ava to v4.3.3. This version of ava adds compatibility with Node 18.8.
Merge / deployment checklist