Add workflowEventName util function - #1238
Merged
Daverlo merged 4 commits intoSep 8, 2022
Merged
Daverlo merged 4 commits into
Daverlo merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
approved these changes
Sep 7, 2022
Comment thread
src/actions-util.ts
Outdated
| if (value === undefined || value.length === 0) { | ||
| return process.env["GITHUB_EVENT_NAME"]; | ||
| } | ||
| return value |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Minor: I think the build will fail because of this.
Suggested change
| return value | |
| return value; |
Sorry, something went wrong.
This was referenced Sep 14, 2022
This was referenced Jun 22, 2023
This was referenced Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the 1 click setup feature of Code Scanning we are planning on use the dynamic workflows internal api. Triggering an action run this way changes the content of GITHUB_EVENT_NAME to dynamic. As we will be triggering this run after a push/pr and the action does some work in those cases, we will be providing the real event name under the env var CODESCANNING_EVENT_NAME.
Merge / deployment checklist