FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

python-setup: Allow newest `virtualenv` by RasmusWL · Pull Request #1256 · github/codeql-action · GitHub

/ codeql-action Public

python-setup: Allow newest virtualenv - #1256

Merged
RasmusWL merged 1 commit into
mainfrom
rasmuswl/newer-virtualenv
Sep 21, 2022
ConversationCommits (1)ChecksFiles changed
Merged

python-setup: Allow newest virtualenv#1256
RasmusWL merged 1 commit into
mainfrom
rasmuswl/newer-virtualenv

Conversation

RasmusWL commented Sep 16, 2022

Copy link
Copy Markdown
Member

Context for previous version is
#862

Locally, I was able to install 20.15.1 with Python2.

I don't see any reason why python3 version should be restricted.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

python-setup: Allow newest virtualenv
5ffcfe9 
Context for previous version is
#862

Locally, I was able to install `20.15.1` with Python2.

I don't see any reason why python3 version should be restricted.
RasmusWL requested review from a team as code owners September 16, 2022 18:51
aeisenberg reviewed Sep 16, 2022
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for following up on this. I think this looks fine, but I just want to clarify my understanding.

With this change, the install_tools scripts will install the latest version of virtualenv that is not 20.12.0 (on python2) and the latest version on python3?

Since the latest version is now 20.15 and going up, the range restriction is not being used.

RasmusWL commented Sep 19, 2022

Copy link
Copy Markdown
Member Author

With this change, the install_tools scripts will install the latest version of virtualenv that is not 20.12.0 (on python2) and the latest version on python3?

Since the latest version is now 20.15 and going up, the range restriction is not being used.

Correct on both. I guess we could remove the range restriction entirely, if you prefer 😊

yoff reviewed Sep 19, 2022
View reviewed changes

yoff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is fine as far as I can tell. Is there a way to test it?

RasmusWL commented Sep 19, 2022

Copy link
Copy Markdown
Member Author

This is fine as far as I can tell. Is there a way to test it?

sure, see the jobs at https://github.com/github/codeql-action/actions/runs/3070050275

RasmusWL requested a review from yoff September 19, 2022 09:11

yoff commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

This is fine as far as I can tell. Is there a way to test it?

sure, see the jobs at https://github.com/github/codeql-action/actions/runs/3070050275

Ah, thanks 👍

yoff approved these changes Sep 19, 2022
View reviewed changes

yoff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

RasmusWL merged commit c2c7bba into main Sep 21, 2022
RasmusWL deleted the rasmuswl/newer-virtualenv branch September 21, 2022 07:05
This was referenced Sep 21, 2022
Merged
Merged
This was referenced Jun 22, 2023
Open
Open
This was referenced Nov 30, 2023
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg left review comments
yoff yoff approved these changes
henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL