python-setup: Add support for Poetry 1.2 - #1258
Merged
RasmusWL merged 4 commits intoSep 21, 2022
Merged
RasmusWL merged 4 commits into
RasmusWL merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
RasmusWL
marked this pull request as ready for review
September 19, 2022 11:16
tausbn
previously approved these changes
Sep 19, 2022
tausbn
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
This looks reasonable to me. 👍
Sorry, something went wrong.
Comment thread
python-setup/auto_install_packages.py
Outdated
henrymercer
previously approved these changes
Sep 20, 2022
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
A small tweak to the changelog note and an optional comment.
Sorry, something went wrong.
Co-authored-by: Henry Mercer <henrymercer@github.com>
henrymercer
previously approved these changes
Sep 20, 2022
Comment thread
python-setup/auto_install_packages.py
Outdated
henrymercer
approved these changes
Sep 21, 2022
This was referenced Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1241
Merge / deployment checklist