| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Seems sensible. I think this could warrant a changenote.
Sorry, something went wrong.
Since we haven't enabled this feature yet for any external users, nor made any promises about the specifics of its behaviour, I think it's reasonable to put in a change like this without another change note. Happy to add one if you disagree, though. |
Sorry, something went wrong.
There was a problem hiding this comment.
Since we haven't enabled this feature yet for any external users, nor made any promises about the specifics of its behaviour, I think it's reasonable to put in a change like this without another change note.
👍
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Our telemetry shows that in a fair amount of cases we get some very small TRAP caches because the repository contains only a very small cacheable amount of the language being analyzed. In this case, we get slight performance regressions because the extra network calls just aren't worth doing for so little information. Let's set a minimum size of cache that we will consider worth uploading, so that we don't waste time uploading (and then redownloading) caches that are just too small to be worth it.
Empirically, 10MB is a good threshold for this because it is around 2MB more than the size of the TRAP for the JavaScript standard library, so this represents us actually caching some useful things beyond this. Other languages might have a different threshold for what is considered a big enough cache to be useful - we can explore that further (guided by our telemetry) once we get to implementing this feature for other languages.
There'll still be some small caches in the internal repos that had the feature flag on, but these should disappear on their own after around a week since that's the retention time of the GitHub Actions cache.
Merge / deployment checklist