FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Correct program name by jsoref · Pull Request #1268 · github/codeql-action · GitHub

Correct program name - #1268

Merged
edoardopirovano merged 1 commit into
github:mainfrom
jsoref:rev-parse
Sep 28, 2022
Merged

edoardopirovano merged 1 commit into
github:mainfrom
jsoref:rev-parse

Conversation

jsoref commented Sep 25, 2022

Copy link
Copy Markdown
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

jsoref requested a review from a team as a code owner September 25, 2022 03:27
yoff previously approved these changes Sep 26, 2022

yoff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @jsoref, thank you for your contribution! Just one more step before we can merge this — please could you follow the steps in https://github.com/github/codeql-action/blob/main/CONTRIBUTING.md#development-and-testing to build the Action? This should update the lib/actions-util.js and lib/actions-util.js.map files. Once you've checked these in, the PR checks should go green.

edoardopirovano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks you!

edoardopirovano merged commit 28c63d1 into github:main Sep 28, 2022
jsoref deleted the rev-parse branch September 28, 2022 11:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL