FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add the `CliConfigFileEnabled` feature flag by aeisenberg · Pull Request #1270 · github/codeql-action · GitHub

/ codeql-action Public

Add the CliConfigFileEnabled feature flag - #1270

Merged
aeisenberg merged 3 commits into
mainfrom
aeisenberg/cli-config-feature-flag
Sep 28, 2022
ConversationCommits (3)ChecksFiles changed
Merged

Add the CliConfigFileEnabled feature flag#1270
aeisenberg merged 3 commits into
mainfrom
aeisenberg/cli-config-feature-flag

Conversation

aeisenberg commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

Also, wire it up to the useCodeScanningConfigInCli function.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

aeisenberg requested a review from a team as a code owner September 27, 2022 02:57
henrymercer previously approved these changes Sep 27, 2022
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks reasonable.

henrymercer reviewed Sep 27, 2022
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Actually, there's a typo here

Comment thread src/util.ts Outdated

aeisenberg commented Sep 27, 2022

Copy link
Copy Markdown
Contributor Author

I'm going to add some unit tests.

aeisenberg force-pushed the aeisenberg/cli-config-feature-flag branch from c72eb20 to 22bbeb8 Compare September 27, 2022 14:34
Add the CliConfigFileEnabled feature flag
e37b0d6 
Also, wire it up to the `useCodeScanningConfigInCli` function.
aeisenberg force-pushed the aeisenberg/cli-config-feature-flag branch from 22bbeb8 to e37b0d6 Compare September 27, 2022 14:58
angelapwen reviewed Sep 27, 2022
View reviewed changes
Comment thread src/util.test.ts Outdated
aeisenberg commented Sep 27, 2022
View reviewed changes
Comment thread src/util.test.ts Outdated
angelapwen previously approved these changes Sep 27, 2022
View reviewed changes

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me 😸

angelapwen commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

Autogenerated JS files are not up to date, but otherwise ✅

aeisenberg force-pushed the aeisenberg/cli-config-feature-flag branch from 5cc1af9 to cab46c5 Compare September 27, 2022 22:49

angelapwen commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

I think the failures are related to the Go extraction feature flag I just enabled. I un-enabled it again and they should work on re-run.

aeisenberg commented Sep 28, 2022

Copy link
Copy Markdown
Contributor Author

Hmmm...required check Download and check debug artifacts is marked as "expected". I'm not sure why it's not running.

angelapwen commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

Hmmm...required check Download and check debug artifacts is marked as "expected". I'm not sure why it's not running.

I've seen this before. I think it's waiting on the upload jobs it depends on to finish, and then it will run.

aeisenberg commented Sep 28, 2022

Copy link
Copy Markdown
Contributor Author

Well...I merged with main and updated all required checks. Hopefully, this is enough to fix things. Yours may have been an easier solution.

aeisenberg merged commit 74740ee into main Sep 28, 2022
aeisenberg deleted the aeisenberg/cli-config-feature-flag branch September 28, 2022 19:43
This was referenced Sep 29, 2022
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

henrymercer henrymercer left review comments
+1 more reviewer
angelapwen angelapwen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL