Add dotnet env variable to workflow - #1273
Merged
angelapwen merged 1 commit intoSep 28, 2022
Merged
angelapwen merged 1 commit into
angelapwen merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
adityasharad
approved these changes
Sep 28, 2022
angelapwen
enabled auto-merge (squash)
September 28, 2022 17:37
auto-merge was automatically disabled
September 28, 2022 19:43
Base branch was modified
This was referenced Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we considered go a non-traced language, and so the tracer was not imported to this workflow at all. Now that we are considering it traced, we need to add this additional environment variable, which is required for our MacOS tests to not time out waiting for a GUI popup.
We already do this in several other Go-specific checks, such as https://github.com/github/codeql-action/blob/main/.github/workflows/__go-custom-tracing-autobuild.yml and https://github.com/github/codeql-action/blob/main/.github/workflows/__go-reconciled-tracing-autobuilder.yml
Merge / deployment checklist