FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable file baseline information behind a feature gate by henrymercer · Pull Request #1329 · github/codeql-action · GitHub

/ codeql-action Public

Enable file baseline information behind a feature gate - #1329

Merged
henrymercer merged 4 commits into
mainfrom
henrymercer/file-baseline-info-enablement
Nov 7, 2022
ConversationCommits (4)ChecksFiles changed
Merged

Enable file baseline information behind a feature gate#1329
henrymercer merged 4 commits into
mainfrom
henrymercer/file-baseline-info-enablement

Conversation

henrymercer commented Oct 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Add feature
  • Use feature to selectively enable --sarif-add-baseline-file-info
  • Wait until we have a 2.11.3 nightly so we can test the PR check we'll implement next.
  • Add PR check that enables the feature using an environment variable

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

henrymercer force-pushed the henrymercer/file-baseline-info-enablement branch from 893e54a to cf9de76 Compare November 1, 2022 17:00
henrymercer force-pushed the henrymercer/file-baseline-info-enablement branch from cf9de76 to 89e1893 Compare November 1, 2022 17:11
henrymercer marked this pull request as ready for review November 7, 2022 16:41
henrymercer requested a review from a team as a code owner November 7, 2022 16:41
aeisenberg approved these changes Nov 7, 2022
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks reasonable.

henrymercer merged commit c606252 into main Nov 7, 2022
henrymercer deleted the henrymercer/file-baseline-info-enablement branch November 7, 2022 18:10
This was referenced Nov 14, 2022
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL