use ATM pack v0.4.0 for CLI v2.11.3 and above - #1351
Merged
kaeluka merged 1 commit intoNov 8, 2022
Merged
kaeluka merged 1 commit into
kaeluka merged 1 commit into
Conversation
kaeluka
force-pushed
the
release-atm-v0.4.0
branch
from
e09bab4 to
5194090
Compare
November 8, 2022 12:36
Copy link
Copy Markdown
Author
|
I'm assuming that README and CHANGELOG don't need to be updated, since the last PR also didn't. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
I'm also assuming that backwards-compatibility is given, but this is my first PR to this repo, so I'm asking the reviewer (@henrymercer?) to confirm that, please :) |
Sorry, something went wrong.
kaeluka
marked this pull request as ready for review
November 8, 2022 12:41
kaeluka
force-pushed
the
release-atm-v0.4.0
branch
from
5194090 to
eaa8869
Compare
November 8, 2022 12:44
kaeluka
force-pushed
the
release-atm-v0.4.0
branch
from
eaa8869 to
01c4458
Compare
November 8, 2022 12:53
henrymercer
approved these changes
Nov 8, 2022
kaeluka
enabled auto-merge
November 8, 2022 13:39
Copy link
Copy Markdown
Contributor
|
Perhaps it is time to start updating the changelog (separate PR is fine), at least for our own convenience. Something similar to what we do when updating the CLI version will suffice: Update the ML-powered additional query pack for JavaScript to version x.y.z. |
Sorry, something went wrong.
This was referenced Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist